Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve ray/serve/generated when creating softlink for serve package #48793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mimiliaogo
Copy link
Contributor

Why are these changes needed?

This PR modifies the setup-dev.py script to preserve ray/serve/generated folder during the symlink creation process. Specifically:

  • Before creating the symbolic link for serve, the existing generated folder is copied to a temporary location.
  • After the symlink is created, the generated folder is moved back to its original location, ensuring that the generated files are preserved and not overwritten by the symlink.

Related issue number

Closes #48792

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ray/serve/generated file is missing after running setup-dev.py
1 participant