Skip to content

Commit 1fa49ac

Browse files
committed
feat: migrate UpdatePolicy API to Connect RPC
1 parent 33067c0 commit 1fa49ac

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

internal/api/v1beta1connect/policy.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ func (h *ConnectHandler) GetPolicy(ctx context.Context, request *connect.Request
8787
return connect.NewResponse(&frontierv1beta1.GetPolicyResponse{Policy: policyPB}), nil
8888
}
8989

90+
func (h *ConnectHandler) UpdatePolicy(ctx context.Context, request *connect.Request[frontierv1beta1.UpdatePolicyRequest]) (*connect.Response[frontierv1beta1.UpdatePolicyResponse], error) {
91+
return nil, connect.NewError(connect.CodeUnimplemented, errors.New("unsupported at the moment"))
92+
}
93+
9094
func (h *ConnectHandler) ListPolicies(ctx context.Context, request *connect.Request[frontierv1beta1.ListPoliciesRequest]) (*connect.Response[frontierv1beta1.ListPoliciesResponse], error) {
9195
var policies []*frontierv1beta1.Policy
9296

internal/api/v1beta1connect/policy_test.go

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,3 +597,31 @@ func TestConnectHandler_ListPolicies(t *testing.T) {
597597
})
598598
}
599599
}
600+
601+
func TestConnectHandler_UpdatePolicy(t *testing.T) {
602+
tests := []struct {
603+
name string
604+
request *connect.Request[frontierv1beta1.UpdatePolicyRequest]
605+
wantErr error
606+
errCode connect.Code
607+
}{
608+
{
609+
name: "should return unimplemented error",
610+
request: connect.NewRequest(&frontierv1beta1.UpdatePolicyRequest{Id: "test-id"}),
611+
wantErr: errors.New("unsupported at the moment"),
612+
errCode: connect.CodeUnimplemented,
613+
},
614+
}
615+
616+
for _, tt := range tests {
617+
t.Run(tt.name, func(t *testing.T) {
618+
handler := &ConnectHandler{}
619+
620+
got, err := handler.UpdatePolicy(context.Background(), tt.request)
621+
assert.Error(t, err)
622+
assert.Equal(t, tt.errCode, connect.CodeOf(err))
623+
assert.Contains(t, err.Error(), tt.wantErr.Error())
624+
assert.Nil(t, got)
625+
})
626+
}
627+
}

0 commit comments

Comments
 (0)