Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong leap year detection #8

Open
MikkiMouse opened this issue Feb 26, 2024 · 1 comment
Open

Wrong leap year detection #8

MikkiMouse opened this issue Feb 26, 2024 · 1 comment

Comments

@MikkiMouse
Copy link

Hi, 1404 year is leap year in Jalali calendar, but library does not define it that way.

JalaliCalendar(1404, 1, 1).isLeap return false but it's not true

Any date in 1404 year is being converted to the Gregorian calendar incorrectly.

Example:

JalaliCalendar(1404, 1, 1).toGregorian() == 21.03.2025 - incorrect
1.1.1404 in Jalali it is 20.03.2025 in Gregorian

It would be cool if this bug is being fixed. Thanks

@razeghi71
Copy link
Owner

Hi @MikkiMouse,

1404 is not a leap year, and the converted date is correct:

Screenshot 2024-05-03 at 12 36 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants