Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Disabled state has poor contrast ratio with new background colors #2133

Open
AnkitaBagale opened this issue Apr 19, 2024 · 5 comments

Comments

@AnkitaBagale
Copy link

Disabled state of button (when isLoading/isDisabled is true), color has poort contrast ratio.
Below is the example of blade modal, footer has 2 buttons.
image

@AritraLeo
Copy link
Contributor

@AnkitaBagale would really appreciate details like -

  1. link to the file (modal)
  2. if this modal is being used a particular modal or not
    Please provide the above details I'd love to work on this issue!

@anuraghazra
Copy link
Member

@AnkitaBagale Can you link the design file for this?

@saurav12 can you check once?

@saurav12
Copy link
Member

@AnkitaBagale @anuraghazra A disabled button doesn't need to pass the contrast ratio test as it is already disabled. Having said that, I agree we should improve the current designs so that even if it doesn't pass the colour contrast, it should look better than the current state. Will look into this but not as a P0/P1 for now.

Reference

@saurav12
Copy link
Member

Also, I believe there is some mismatch with the font-weight inside the button. This is how it looks on Figma (design) right now. Which is different from the screenshot attached above.

image

@FurquanAnwer
Copy link

Can I work on this ? Please assign me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants