Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max age 0 #4

Open
mergenchik opened this issue Jul 19, 2020 · 2 comments
Open

max age 0 #4

mergenchik opened this issue Jul 19, 2020 · 2 comments

Comments

@mergenchik
Copy link

There is a problem in implementation of func (s *RedisStore) Save for corner case of session.Options.MaxAge = 0. Expected behavior for cookie's MaxAge = 0 is to expire cookie when all tabs are closed. For redis, it is never expire.
By putting MaxAge = 0, no cookie nor redis records are stored.
@razorness
Copy link

See boj/redistore@715bb32#commitcomment-31303439

@mrccnt
Copy link

mrccnt commented Oct 16, 2023

I know this is an old one, but just to be clear: If I am using MaxAge = 0 this whole package can not be used at all? I mean yeah I can fork it and make my change there but...? Gorilla sessions are pretty clear when it comes to MaxAge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mergenchik @razorness @mrccnt