Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy lme4 code into package, instead of importing it #253

Open
kenkellner opened this issue May 24, 2023 · 2 comments · May be fixed by #266
Open

Copy lme4 code into package, instead of importing it #253

kenkellner opened this issue May 24, 2023 · 2 comments · May be fixed by #266

Comments

@kenkellner
Copy link
Collaborator

We only use a handful of functions from lme4 for processing random effects (findbars, nobars, mkReTrms). It looks like these functions have not been changed in 5+ years. Given that we don't actually use lme4 to fit models I think it could make more sense to copy these functions to unmarked and remove the dependency on lme4, which would simplify things for both packages. I think the following requirements apply:

  1. Make sure the licenses are compatible (both are GPL-3 so that's fine)
  2. Copy lme4 code to a new file, say lme4Code.R which has comments clearly indicating its origin
  3. Add appropriate authorship. In this case I think we would add "Douglas Bates and lme4 authors (lme4Code.R)" to the package authors.
@kenkellner
Copy link
Collaborator Author

@rbchan What do you think? I'm going to have to do a new submission soon to fix this new CRAN error, so I may make this change for that submission.

@rbchan
Copy link
Owner

rbchan commented Jun 23, 2023

Sounds good to me. You might ask Douglas Bates and the lme4 authors if they want to be listed as unmarked authors.

@kenkellner kenkellner linked a pull request Dec 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants