Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Add Hindi captions to Images.JSON #103

Open
1 task done
adityaraute opened this issue Mar 22, 2024 · 10 comments
Open
1 task done

[FEATURE]: Add Hindi captions to Images.JSON #103

adityaraute opened this issue Mar 22, 2024 · 10 comments
Assignees
@kripa-sindhu-007
Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue Visible on the Good First Issue finder on EddieHub enhancement New feature or request good first issue Good for newcomers

Comments

@adityaraute
Copy link
Collaborator

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

Currently we only have English text in the images.json file for all activities.

Proposed Solution

Added a Hindi caption to each image which can be later used for translations.

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response
@adityaraute adityaraute added the enhancement New feature or request label Mar 22, 2024
@adityaraute adityaraute mentioned this issue Mar 22, 2024
Open
1 task
@adityaraute adityaraute added documentation Improvements or additions to documentation good first issue Good for newcomers EddieHub:good-first-issue Visible on the Good First Issue finder on EddieHub labels Mar 22, 2024
@Chanchal-D
Copy link

Yes, I would like to contribute to this feature and that can be done by first, understanding its structure—an array of image objects. Then, introduce a new field, "hindi_caption", to accommodate Hindi captions. Populate this field for each image object with corresponding captions. Validate the JSON for correctness and test to ensure the Hindi captions display properly.

@adityaraute
Copy link
Collaborator Author

Sounds perfect @Chanchal-D !

@adityaraute
Copy link
Collaborator Author

Hi @Chanchal-D
Please provide an update on this issue

@adityaraute
Copy link
Collaborator Author

Hi @Chanchal-D

Please update on this issue by June 10.
We will have to unassign you if no update is received by then.

@kripa-sindhu-007
Copy link
Contributor

@adityaraute I guess it's 3 days passed June 10 now :)

@adityaraute
Copy link
Collaborator Author

Thanks for informing.

@Chanchal-D unassigning you from this issue due to lack of response.

@kripa-sindhu-007
Copy link
Contributor

@adityaraute can you assign me this issue.i sent a pull request already for this 😅

@adityaraute
Copy link
Collaborator Author

Done. Please link the Pull Request to the issue in the Development section on the right hand side.

@kripa-sindhu-007
Copy link
Contributor

I can do it on Tuesday. I came to my village without my laptop 🥲.

@adityaraute
Copy link
Collaborator Author

Hi @kripa-sindhu-007 please share an update on the issue

@kripa-sindhu-007 kripa-sindhu-007 mentioned this issue Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kripa-sindhu-007 kripa-sindhu-007

Labels
documentation Improvements or additions to documentation EddieHub:good-first-issue Visible on the Good First Issue finder on EddieHub enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adityaraute @Chanchal-D @kripa-sindhu-007