-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very tall Y axis for high BMI on trisomy 21 charts #93
Comments
I think the issue is with the digital-growth-charts-react-component-library/src/functions/getDomainsAndData.ts Line 523 in b6331d2
For the 3.33 SDS line (the rightmost tallest one in the screenshot) the values ramp up quickly and then end up |
Ah I see those are the actual values from the reference set: digital-growth-charts-react-component-library/src/chartdata/trisomy21_bmi_male_sds_data.ts Line 7712 in b6331d2
I think I will need @eatyourpeas input here on how that reference was calculated. There's also rcpch/digital-growth-charts-server#217 raised already for the nulls |
These values were calculated from our chart-coordinates endpoint and are possibly correct because of the way the maths works at higher values. The BMI curves in trisomy I find much less useful clinically for this reason. @statist7 would better be able to comment whether this is an actual error or whether this is more an issue for rendering where we simply apply an arbitrary upper limit to the visible value of y. |
For particular configurations of L, M, S and z, BMI heads off to infinity. The relevant formula is This happens when L is negative (which it nearly always is with BMI) and z is sufficiently large and positive. As @eatyourpeas says, perhaps test for and trap large BMI values. |
Porting across rcpch/digital-growth-charts-server#220 to this repo as it seems to be an issue with the chart rendering rather than the data returned from the API.
Storybook story to reproduce in the mbarton/trisomy21-bmi-rendering-issue branch: 6aa9181
The text was updated successfully, but these errors were encountered: