Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GP postcode instead of ODS code in CSV uploads #213

Open
eatyourpeas opened this issue Jul 23, 2024 · 2 comments
Open

Support GP postcode instead of ODS code in CSV uploads #213

eatyourpeas opened this issue Jul 23, 2024 · 2 comments
Labels
feature New feature or request

Comments

@eatyourpeas
Copy link
Member

In the current NPDA, users are encouraged to look up the ods code for a child's GP themselves here and then add that to their csv submission. A better implementation though would be to accept a GP postcode and retrieve the ODS code from the spine. There is a currently a function gp_practice_for_postcode which does this and works.
We need to decide whether we continue to accept ods codes if supplied, or whether we also accept GP postcodes instead or both.

@mbarton
Copy link
Member

mbarton commented Jul 23, 2024

@eatyourpeas is this for the CSV upload specifically? You can specify either in the UI. Linking this issue to #164 as the current lookup is fussy about spaces

@eatyourpeas
Copy link
Member Author

sorry - yes, that was what i was thinking. NPDA team may tell us that changing the .csv layout is too much of a head ache to do this, so potentially it could just be an option in the UI. We could have a hybrid solution where ODS is an optional field in the csv, and could be updated in the UI optionally using the postcode

@mbarton mbarton added the feature New feature or request label Jul 23, 2024
@mbarton mbarton changed the title GP ODS code vs postcode Support GP postcode instead of ODS code in CSV uploads Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants