Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KPI specifications from excel into markdown, probably documentation site #297

Closed
anchit-chandran opened this issue Oct 5, 2024 · 0 comments
Closed

Move KPI specifications from excel into markdown, probably documentation site #297

anchit-chandran opened this issue Oct 5, 2024 · 0 comments
Assignees
@anchit-chandran
Labels
feature New feature or request good first issue Good for newcomers TODO Not an issue, but a feature to be added

Comments

@anchit-chandran
Copy link
Contributor

anchit-chandran commented Oct 5, 2024 •
edited
Loading

Currently the specifications are written in an Excel sheet (ew), should refactor this into own page in docs site, much easier to update and singular source of truth for easy access

https://github.com/rcpch/national-paediatric-diabetes-audit/blob/live/project/npda/dummy_sheets/kpi-specifications/Calculations_AK_20240621%20(1).xlsx

Might be better to use docstrings for each calculate_kpi_... method found in kpis.py
@anchit-chandran anchit-chandran added feature New feature or request good first issue Good for newcomers TODO Not an issue, but a feature to be added labels Oct 5, 2024
@anchit-chandran anchit-chandran mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anchit-chandran anchit-chandran

Labels
feature New feature or request good first issue Good for newcomers TODO Not an issue, but a feature to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reecehill @anchit-chandran