Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waffle plots are still broken in staging #471

Closed
mbarton opened this issue Jan 10, 2025 · 2 comments · Fixed by #472
Closed

Waffle plots are still broken in staging #471

mbarton opened this issue Jan 10, 2025 · 2 comments · Fixed by #472

Comments

@mbarton
Copy link
Member

mbarton commented Jan 10, 2025

Screenshot from 2025-01-10 15-55-31
@mbarton
Copy link
Member Author

mbarton commented Jan 10, 2025 

AttributeError: 'list' object has no attribute 'items'

It looks like the fix in #469 is what has broken staging, need to look at why data is a dictionary when I run locally but a list in staging

@mbarton
Copy link
Member Author

mbarton commented Jan 10, 2025

Probably hitting this branch here:

national-paediatric-diabetes-audit/project/npda/views/dashboard/partials.py

Line 144 in 65e0c09

data = sorted(data.items(), key=lambda item: item[1], reverse=False)

@mbarton mbarton mentioned this issue Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better fix for waffles not working rcpch/national-paediatric-diabetes-audit
1 participant
@mbarton