Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visit form all fields must be valid before save #99

Closed
eatyourpeas opened this issue Jun 6, 2024 · 1 comment
Closed

visit form all fields must be valid before save #99

eatyourpeas opened this issue Jun 6, 2024 · 1 comment
Labels
feature New feature or request

Comments

@eatyourpeas
Copy link
Member

Now that all the form fields are in tabs, it maybe that invalid fields are in tabs that are not active. This is nicely signposted by highlighting the tab label as red but it might be that users will not see that and try and save and be frustrated when the form is represented.
Perhaps instead we could allow the form to save, but present a modal 'There are still some errors in [....]. Are you sure you want to save what you have done?' or something similar.

@eatyourpeas eatyourpeas added the feature New feature or request label Jun 6, 2024
@mbarton
Copy link
Member

mbarton commented Jul 18, 2024

Closing as you can now save an invalid visit

@mbarton mbarton closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants