Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NHS Number Error #516

Closed
AmaniKrayemRCPCH opened this issue Jul 6, 2023 · 3 comments
Closed

NHS Number Error #516

AmaniKrayemRCPCH opened this issue Jul 6, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@AmaniKrayemRCPCH
Copy link
Contributor

Image

I couldn't add a new patient, as the platform flagged the NHS number as the wrong number of digits.
I tried 076 102 2163 and that also didn't work. 883 501 0039 did work. These numbers came from a random generator - http://danielbayley.uk/nhs-number/

I assume it rejected the first two attempts as the NHS number began with 0.
@eatyourpeas
Copy link
Member

Yes that is correct. At least the error handling is working! @pacharanero has since created a new package for NHS numbers with a number of colleagues from across the health tech community and our testing branch has that working. So I will leave this issue here for the moment, but once the testing branch has merged (probably tomorrow) into development, we can close this. Thank you for spotting!

@anchit-chandran
Copy link
Collaborator

Duplicate of / will be fixed on completion of #515

@anchit-chandran anchit-chandran added the duplicate This issue or pull request already exists label Jul 7, 2023
@eatyourpeas
Copy link
Member

this is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eatyourpeas @anchit-chandran @AmaniKrayemRCPCH