Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Secrets for this repo contain a number of variables which are not needed #556

Closed
pacharanero opened this issue Aug 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pacharanero
Copy link
Member

In the GitHub Pages Secrets there are a number of variables which are not needed. These need to be removed, as it is confusing for other developers to see Secrets in the repo admin section but these are not referenced in the workflows, or necessary at all.

Some of the variables are duplicated in the env: section of the GH Actions workflow file
https://github.com/rcpch/rcpch-audit-engine/actions/runs/5987300441/workflow

The secrets can be seen here for those with appropriate access permissions
https://github.com/rcpch/rcpch-audit-engine/settings/secrets/actions

We need to go through and remove the Secrets which are not needed.

@pacharanero pacharanero added the bug Something isn't working label Aug 30, 2023
@pacharanero
Copy link
Member Author

I have deleted all the unused Secrets now. The way we are deploying does not require GH Secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants