-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncsOperatorList
read as doubles - mmtf spec says should be floats.
#53
Comments
ncsOperatorList
read as a double - mmtf specification says this should be floats.ncsOperatorList
read as doubles - mmtf spec says should be floats.
Unfortunately this is breaking cross compatibility with |
I have a partial workaround, by making |
Good catch @zacharyrs ! Thanks for the detailed report. Changing the RCSB mmtf files is doable but as you say may cause quite some trouble. I like your python workaround as a solution. However, to be consistent the spec would have to officially acknowledge that ncsOperList uses doubles, right? One important note. MMTF is now is in minimal maintenance mode. The preferred compressed format for PDB data is BinaryCIF. |
Thanks @josemduarte! Yes, the python solution basically just means both implementations violate the specification in the same way. It avoids the hassle of breaking things. I didn't realise I recall |
Yes, that's correct
Bond information is available but indirectly via the chemical component dictionary |
Is that guaranteed for all molecules or is it optional? |
The chemical component dictionary contains all intra-residue bond information. But it is not embedded within the structure BCIF files. We will consider offering the whole chemical component dictionary as one BCIF bundle that should make it more convenient to use. |
When unpacking an
mmtf
file, this implementation expects doubles for the transformation matrices.The specification outlines the float type as 32bit, and says this field is populated with floats.
Not sure if this should be changed - I suspect it might break parsing existing
mmtf
files, so maybe it needs to accept both types?The text was updated successfully, but these errors were encountered: