Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hdt version #83

Closed
LaurensRietveld opened this issue Aug 24, 2017 · 9 comments
Closed

New hdt version #83

LaurensRietveld opened this issue Aug 24, 2017 · 9 comments
Assignees
Milestone

Comments

@LaurensRietveld
Copy link
Member

What about merging develop to master? I've been using the latest develop branch intensively and it seems there are no issues that should stop it from becoming the next version.
If we do the merge soon, we can use the develop branch to start properly testing the new compilation procedure (#81)

@RubenVerborgh
Copy link
Member

Agree, let's do exactly that: merge to master and start testing #81.
However, I'd also propose that merging to master is accompanied by a new version number, and that we have explicit version commit from now on.

Given the breaking changes, I propose to release v2.0.0 of the library. The supported HDT format will still be v1.0.0. And, if I'm not mistaken, the index file format has not changed, so we do not need a version bump there either.

@RubenVerborgh
Copy link
Member

RubenVerborgh commented Aug 24, 2017

Hmm, in the milestones list, I see that we were working toward v1.2.0 (https://github.com/rdfhdt/hdt-cpp/milestone/1). However, if we follow semver, we need to make this a major release, since the API is not backward compatible.

We might, however, choose to not use semver, but instead have the major version number reflect the supported HDT format.

@LaurensRietveld
Copy link
Member Author

I like the idea of having the major version number reflect the HDT format. I guess the next major release would then be when the long-dict-id branch is merged.
So, we'd have a new 1.2 release, and move the remaining milestone issues to the following release?

@RubenVerborgh
Copy link
Member

I'd just like to have a look at #77, or in the very least ensure that the default parser is Serdi, such that all generated HDT files are always valid. I'll take this up.

@RubenVerborgh RubenVerborgh self-assigned this Aug 24, 2017
@RubenVerborgh RubenVerborgh added this to the v1.2.0 milestone Aug 24, 2017
@RubenVerborgh
Copy link
Member

On second thoughts, let's tackle #77 when the new build system is in place.

I'll take care of the 1.2.0 release, but I just want to ensure that the README is correct and that no more broken HDT files can be generated.

@RubenVerborgh
Copy link
Member

Released 1.2.0 in cd79e49.

@RubenVerborgh
Copy link
Member

Had to retract 1.2.0 😞 Querying is broken (#84).

@RubenVerborgh RubenVerborgh reopened this Aug 24, 2017
@LaurensRietveld
Copy link
Member Author

Ai, that's too bad. Good catch though

@RubenVerborgh
Copy link
Member

Released a working 1.2.0: https://github.com/rdfhdt/hdt-cpp/releases/tag/v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants