Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntactically invalid export to RDF #85

Closed
LaurensRietveld opened this issue Aug 25, 2017 · 5 comments
Closed

Syntactically invalid export to RDF #85

LaurensRietveld opened this issue Aug 25, 2017 · 5 comments
Assignees
Labels

Comments

@LaurensRietveld
Copy link
Member

The serdi serializer does not always return syntactically valid RDF. Luckily we reverted the latest release so we can still fix this ;)

 echo '<http://sub> <http://pred> "@some-string" .' > test.nt && rdf2hdt test.nt test.hdt && hdt2rdf test.hdt - | serdi  -
<http://sub> <http://pred> "@some-string\""@some-string .
error: (stdin):1:56: missing ';' or '.'
@drobilla
Copy link
Contributor

This exact same problem seems to happen with the raptor parser/serializer as well. The serd one chops up string literals in the same way.

@drobilla
Copy link
Contributor

#86

@RubenVerborgh
Copy link
Member

Thanks! @LaurensRietveld, can you verify #86?

@LaurensRietveld
Copy link
Member Author

Look good to me. As @drobilla mentioned, the raptor serializer fails as well. And, as raptor takes precedence over raptor when serializing (see https://github.com/rdfhdt/hdt-cpp/blob/master/hdt-lib/src/rdf/RDFSerializer.cpp#L18), the serialization might still produce invalid output when raptor is listed as dep. I propose to tackle this issue in #77, by removing raptor completely for serialization.

@RubenVerborgh
Copy link
Member

Okay, will go ahead and merge #86 then (and fix #77 soon after).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants