We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The spec doesn't seem to be very clear on WebGLObjects. But w/ WebGLTexture objects, Lightning attempts to assign it's own properties..
https://github.com/rdkcentral/Lightning/blob/master/src/renderer/webgl/WebGLRenderer.mjs#L217-L218
Here it uses a WebGLTexture to call hasOwnProperty https://github.com/rdkcentral/Lightning/blob/master/src/tree/TextureManager.mjs#L123
hasOwnProperty
This seems to not be a problem with most browser implementations, but could be an issue with more esoteric platforms.
Wanted to get feedback on this prior to any contribution.
The text was updated successfully, but these errors were encountered:
Hey @estobbart ! Fair point, lets discuss this somewhere this week --> @uguraslan @erikhaandrikman Happy to learn more about your project tho =P
Sorry, something went wrong.
No branches or pull requests
The spec doesn't seem to be very clear on WebGLObjects.
But w/ WebGLTexture objects, Lightning attempts to assign it's own properties..
https://github.com/rdkcentral/Lightning/blob/master/src/renderer/webgl/WebGLRenderer.mjs#L217-L218
Here it uses a WebGLTexture to call
hasOwnProperty
https://github.com/rdkcentral/Lightning/blob/master/src/tree/TextureManager.mjs#L123
This seems to not be a problem with most browser implementations, but could be an issue with more esoteric platforms.
Wanted to get feedback on this prior to any contribution.
The text was updated successfully, but these errors were encountered: