Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes WebGLObjects are extensible and include an Object prototype #463

Open
estobbart opened this issue Mar 6, 2023 · 1 comment
Open

Comments

@estobbart
Copy link

The spec doesn't seem to be very clear on WebGLObjects.
But w/ WebGLTexture objects, Lightning attempts to assign it's own properties..

https://github.com/rdkcentral/Lightning/blob/master/src/renderer/webgl/WebGLRenderer.mjs#L217-L218

Here it uses a WebGLTexture to call hasOwnProperty
https://github.com/rdkcentral/Lightning/blob/master/src/tree/TextureManager.mjs#L123

This seems to not be a problem with most browser implementations, but could be an issue with more esoteric platforms.

Wanted to get feedback on this prior to any contribution.

@wouterlucas
Copy link
Contributor

Hey @estobbart ! Fair point, lets discuss this somewhere this week --> @uguraslan @erikhaandrikman
Happy to learn more about your project tho =P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Hold
Development

No branches or pull requests

3 participants