Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the f-droid build to this fork #1

Open
Bubu opened this issue Oct 10, 2017 · 7 comments
Open

Switching the f-droid build to this fork #1

Bubu opened this issue Oct 10, 2017 · 7 comments

Comments

@Bubu
Copy link

Bubu commented Oct 10, 2017

MapEver is currently only in the archive repo at f-droid and there is demand to get this back to the main repo: diedricm#23

Even better would be of course to include all the fixes you have done which are not yet included in any release in diedricm/MapEver.

Would it work if I switch the f-droid app to this repo and add your version 1.1.1 as an update to the existing MapEver?

@rdoeffinger
Copy link
Owner

Yes, I think that should be fine, though note that I threw out all the OpenCV stuff, if someone was particularly attached to e.g. the automatic corner detection they might be disappointed (never worked in a useful way for me, and a pain to build and maintain).
That might also mean you don't need submodule support.
I might also make sense to have it automatically update for new tags like the QuickDic build does.

@Bubu
Copy link
Author

Bubu commented Oct 14, 2017

Thanks for the answer.
The old version will still be in the archive if someone wants it. I'll do this in the next couple of days then.

@Bubu
Copy link
Author

Bubu commented Oct 14, 2017

I tried to build this but got the following error:

:MapEver:compileReleaseJavaWithJavac/home/mhoffmann/projects/oss/fdroiddata/build/de.hu_berlin.informatik.spws2014.mapever/MapEver/src/de/hu_berlin/informatik/spws2014/mapever/navigation/Navigation.java:497: error: cannot find symbol
                GpsPoint pos = locationDataManager.getGpsPosition(mapView.longClickPos);
                                                  ^
  symbol:   method getGpsPosition(Point2D)
  location: variable locationDataManager of type LocationDataManager

Any ideas?
(Running gradle assembleRelease)

@rdoeffinger
Copy link
Owner

I was wrong about the submodules.
There is still a submodule for src/de/hu_berlin/informatik/spws2014/ImagePositionLocator.
Your error indicates you have the wrong (and old) version of that submodule.

@rdoeffinger
Copy link
Owner

Hm... Also the submodule URL is wrong, it should have pointed to my fork of ImagePositionLocator.
I didn't want to make a new release yet, so I only made a v1.1.2 tag that is identical except for that fix.
It seemed to work fine like this:
git clone --recurse-submodules [email protected]:rdoeffinger/MapEver.git -b v1.1.2

@orivej
Copy link

orivej commented Feb 7, 2018

@Bubu Would you package this for F-Droid?

@davidmef
Copy link

davidmef commented Nov 1, 2021

I see that there is a September 2021 version on Google Play. Is the source code in this repo?
Are there obstacles to distribute this with F-Droid as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants