-
Notifications
You must be signed in to change notification settings - Fork 38
Add GitHub Actions. #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pboling do you have any time to check this (and mentioned PRs)? |
Sure! I will take a look in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will extend GHA soon to a more robust matrix, this is a great start. |
Good luck! Feel free to ping me if you need help. |
Was is all the warning output that made you remove rubocop-lts? I am working on a new version to support the new lint roller plugin architecture. I assume that is what you meant by "modern" 😎 |
The goal of rubocop-lts is to ensure, as best we are able, proper ruby syntax for old Rubies, especially ones we can't easily run anymore. Ruby 2.0, 2.1, 2.2, don't run at all in vanilla GHA anymore, so we can't add them to matrix without extreme effort. Rubocop-lts is my feeble answer to that dilemma. And I don't support dropping Rubies without major version bump (following strict SemVer). |
@pboling I don't remember a lot. I remember I was able to get rubocop running, but it was full of errors I consider to ignore it for now to keep PRs reasonably scoped. However this gem is used mostly (IMHO like 99%) as a dependency of googleauth gem and that one is currenty Ruby 3.0+ only. I think it is ok to cut new release oriented around 3.0+. But if you do major version bump, googleauth gen would not be able to onboard new os release since there is strict constraint https://github.com/googleapis/google-auth-library-ruby/blob/9c5f55d9fbc9d189236964970215a3cbbb35b1da/googleauth.gemspec#L30. Thus it would be good to get in touch with Google guys and coordinate release together to make it compatible with new os major release also. Btw. I'm on Bundler Slack to discuss anything in more effective way. I have left you message there, happy to move there for other topics if welcomed. |
That may be a large user of this gem, but this gem is far larger than that. I have never used that gem, and I work with many libraries and apps that depend on this gem, which is why I got involved. There are more modern alternatives, but I think this one is used so much in part because of the ancient support. A gem like this, which provides an easy way to add OS dependent tests for CI, will be used by libraries that support any Ruby, so dropping Ruby support should be carefully considered. This is the 110th largest gem in ruby by downloads. |
Passes if other PRs (#82, #81, #80) are merged first. You can see it in action at RubyElders#2.
I had to remove
rubocop-lts
for now. I'm happy to add rubocop back in modern way.fixes #57