Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with v7: precision and formatter collide #320

Open
Mathieuu opened this issue Apr 23, 2021 · 1 comment
Open

Regression with v7: precision and formatter collide #320

Mathieuu opened this issue Apr 23, 2021 · 1 comment

Comments

@Mathieuu
Copy link

Since v7, the precision is skipped if a formatter is passed.

Here's an example with precision 2 and a formatter adding columns for every thousand: 100,000.00

With v6.1.2:
https://codesandbox.io/s/spring-sunset-dwr0o?file=/src/App.js

With v7
https://codesandbox.io/s/trusting-dan-vmhmc?file=/src/App.js

Here's the fault line: https://github.com/react-component/input-number/blob/master/src/InputNumber.tsx#L175

I am not sure what the right fix would be though.

@Mathieuu Mathieuu changed the title Regression with v7: precision and formatter can no longer be used together Regression with v7: precision and formatter collide Apr 23, 2021
@bombillazo
Copy link

Here to comment on the same, seems like this is not a priority but its a big development pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants