From 55e35d60ca9d0cc17d54e0d836b05c2727a3151a Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Wed, 9 Apr 2025 21:11:02 -0400 Subject: [PATCH 1/2] fix: fix typing of BaseSelectProps.className (fixes #1143) --- src/BaseSelect/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BaseSelect/index.tsx b/src/BaseSelect/index.tsx index d19ee824a..79bb97e0b 100644 --- a/src/BaseSelect/index.tsx +++ b/src/BaseSelect/index.tsx @@ -129,7 +129,7 @@ export type BaseSelectPropsWithoutPrivate = Omit>; styles?: Partial>; From 86787f5f69a13c523d71ef37c7e330b86c79c1f7 Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Tue, 22 Apr 2025 03:26:14 -0400 Subject: [PATCH 2/2] Fix all classname related references. --- src/BaseSelect/index.tsx | 4 ++-- src/Select.tsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/BaseSelect/index.tsx b/src/BaseSelect/index.tsx index 79bb97e0b..f8a17d4f0 100644 --- a/src/BaseSelect/index.tsx +++ b/src/BaseSelect/index.tsx @@ -129,7 +129,7 @@ export type BaseSelectPropsWithoutPrivate = Omit>; styles?: Partial>; @@ -195,7 +195,7 @@ export interface BaseSelectProps extends BaseSelectPrivateProps, React.AriaAttri transitionName?: string; popupStyle?: React.CSSProperties; - popupClassName?: string; + popupClassName?: string | undefined; popupMatchSelectWidth?: boolean | number; popupRender?: (menu: React.ReactElement) => React.ReactElement; popupAlign?: AlignType; diff --git a/src/Select.tsx b/src/Select.tsx index 39da90411..017d71107 100644 --- a/src/Select.tsx +++ b/src/Select.tsx @@ -90,7 +90,7 @@ export interface FieldNames { export interface BaseOptionType { disabled?: boolean; - className?: string; + className?: string | undefined; title?: string; [name: string]: any; }