Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as prop does not take precedence over components #88

Open
IanVS opened this issue Dec 3, 2021 · 2 comments
Open

as prop does not take precedence over components #88

IanVS opened this issue Dec 3, 2021 · 2 comments

Comments

@IanVS
Copy link
Contributor

IanVS commented Dec 3, 2021

As seen in #87 (comment), as does not take precedence over render if the value provided to it is a component rather than an element.

The snapshot generated in #87 is not correct, and should be fixed.
@IanVS IanVS mentioned this issue Dec 3, 2021
Merged
@bluebill1049
Copy link
Member

Thank you very much @IanVS sorry for the delay response. Merged and released.

@IanVS
Copy link
Contributor Author

IanVS commented Dec 7, 2022

The PR mentioned above #87 does not fix this issue, it was spawned from that PR, but a new PR is needed. https://github.com/react-hook-form/error-message/pull/87/files/f0d5c51b3d04006eaa6bf19ed7224a312cbdb0f6#r762061758

I think this should be re-opened.

@bluebill1049 bluebill1049 reopened this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanVS @bluebill1049