-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuración para instalar yarn en el readme #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @gajamo, thanks for your collaboration!
You have a typo in the readme, can you please update it. This PR should be good to go after you make that change!
Thanks again!
README.md
Outdated
|
||
## Install yarn on Windows | ||
|
||
There are three options for installing Yarn on Windows, you can fine <a href="https://yarnpkg.com/lang/en/docs/install/#windows-stable" target="_blank">here</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, typo here: This should be you can find
instead of you can fine
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Gracias, ya corregir el tema del fine, adicional agregue como instalar las dependencias con yarn y probar si se tiene instalado yarn con el yarn --version, gracias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @gajamo
This is looking good so far, a couple of changes here.
- The project uses
yarn
instead ofnpm
's lockfile. That said, you'd need to delete the package-lock.json file and add it to the.gitignore
file - Instead of listing all the instructions to install yarn, it would be better to add a link pointing to Yarn's docs official site. By doing that, we will be sure that our documentation is always up to date.
Let me know if you have any question!
Delete package-lock.json and add to .gitignore, and add link to Yarn's docs official site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gajamo Almost there,
Please fix the merge conflicts you have so we can merge this! 👍
Merged, thanks @gajamo ! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5
What is the new behavior?
Does this PR introduce a breaking change?
Other information