Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuración para instalar yarn en el readme #37

Merged
merged 26 commits into from
Oct 30, 2018

Conversation

gajamo
Copy link
Contributor

@gajamo gajamo commented Oct 16, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5

What is the new behavior?

Does this PR introduce a breaking change?

[] Yes
[x] No

Other information

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gajamo, thanks for your collaboration!

You have a typo in the readme, can you please update it. This PR should be good to go after you make that change!

Thanks again!

README.md Outdated

## Install yarn on Windows

There are three options for installing Yarn on Windows, you can fine <a href="https://yarnpkg.com/lang/en/docs/install/#windows-stable" target="_blank">here</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, typo here: This should be you can find instead of you can fine :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Gracias, ya corregir el tema del fine, adicional agregue como instalar las dependencias con yarn y probar si se tiene instalado yarn con el yarn --version, gracias

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @gajamo

This is looking good so far, a couple of changes here.

  1. The project uses yarn instead of npm's lockfile. That said, you'd need to delete the package-lock.json file and add it to the .gitignore file
  2. Instead of listing all the instructions to install yarn, it would be better to add a link pointing to Yarn's docs official site. By doing that, we will be sure that our documentation is always up to date.

Let me know if you have any question!

@gajamo
Copy link
Contributor Author

gajamo commented Oct 26, 2018

Delete package-lock.json and add to .gitignore, and add link to Yarn's docs official site.

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajamo Almost there,

Please fix the merge conflicts you have so we can merge this! 👍

Gabriel Jairme Moreno Cifuentes added 2 commits October 29, 2018 08:04
@alejandronanez alejandronanez merged commit 1c7ee94 into react-medellin:master Oct 30, 2018
@alejandronanez
Copy link
Member

Merged, thanks @gajamo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants