iOS: opens on long press regardless of shouldOpenOnLongPress setting

[erquhart]

The menu always opens on long press.

[JacksonML]

#983 Might be related to this, I started looking into the code in the repo and this PR is pretty much what I was coming up with as a fix.

[yyyyyyounger]

I still encounter this problem in 1.2.2.
With this code structure it always happens:

<MenuView>
  <Touchable... />
</MenuView>

Device: iOS 18.3 (Android will not happen when set the shouldOpenOnLongPress false)

[marcosrdz]

I suggest renaming that prop to something less confusing. Perhaps isOpenOnPress? Something that doesnt imply that it will never open on long press

[erquhart]

isOpenOnPress would be very confusing for me 😅

menu/ios/MenuViewManager.mm

Lines 68 to 71 in 09a142f

	/**
	* shouldOpenOnLongPress: determines whether menu should be opened after long press or normal press
	*/
	RCT_EXPORT_VIEW_PROPERTY(shouldOpenOnLongPress, BOOL)

If this doc is accurate, it seems it's named fine and is just broken, but I could definitely be missing something here.

[marcosrdz]

isOpenOnPress would be very confusing for me 😅

menu/ios/MenuViewManager.mm

Lines 68 to 71 in 09a142f

	/**
	* shouldOpenOnLongPress: determines whether menu should be opened after long press or normal press
	*/
	RCT_EXPORT_VIEW_PROPERTY(shouldOpenOnLongPress, BOOL)

If this doc is accurate, it seems it's named fine and is just broken, but I could definitely be missing something here.

shouldOnlyOpenOnLongPress?

[marcosrdz]

isOpenMenuPrimaryAction?

Multiple ways to name it

[erquhart]

I just don't think the name is the problem - this issue is about the setting effectively doing nothing, it's a bug.