Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using Sapphire framework #46

Closed
nickserv opened this issue Feb 25, 2020 · 7 comments
Closed

Consider using Sapphire framework #46

nickserv opened this issue Feb 25, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@nickserv
Copy link
Contributor

nickserv commented Feb 25, 2020 •
edited
Loading

@nickserv nickserv added the enhancement New feature or request label Feb 25, 2020
@nickserv nickserv self-assigned this Feb 25, 2020
@nickserv nickserv changed the title Consider using gears Consider using bot libraries Nov 30, 2020
@nickserv
Copy link
Contributor Author

nickserv commented Dec 19, 2020 •
edited
Loading

Alternatively we could use application commands which seem to have a much better UX.

@nickserv
Copy link
Contributor Author

nickserv commented Dec 17, 2021 •
edited
Loading

Gears and Commando don't seem to support discord.js 13, and I don't think it's worth the effort switching to another library when discord.js already has thread support, so I'll close this for now.

@nickserv nickserv mentioned this issue Dec 17, 2021
Open
@nickserv nickserv added the wontfix This will not be worked on label Dec 30, 2021
@nickserv

This comment has been minimized.

Sign in to view
@nickserv
Copy link
Contributor Author

nickserv commented Jan 2, 2022 •
edited
Loading

I closed this before realizing that discord.js has replaced Commando with Sapphire. Sapphire supports threads, provides helpers for command management (would be great to enable more contributors), enables editable commands, and builds on discord.js (which we're already using), so it may be worth looking into at some point in the future.

That being said, I'm not going to prioritize this, as I'd rather focus on improvements that introduce new features or immediately improve UX (such as #131) for now. We can decide if using Sapphire would make things easier for us later.

@nickserv nickserv reopened this Jan 2, 2022
@nickserv nickserv changed the title Consider using bot libraries Consider using Sapphire framework Jan 2, 2022
@nickserv nickserv removed the wontfix This will not be worked on label Jan 2, 2022
@nickserv nickserv removed their assignment Jan 2, 2022
@Padmanabh82
Copy link

@nickmccurdy do we need this ??? If not please close this

@nickserv
Copy link
Contributor Author

I'd still like to look into this more, it's just not a priority right now

@vcarl
Copy link
Member

vcarl commented Dec 28, 2023

I'm going to close this as it's 3 years old

@vcarl vcarl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickserv @vcarl @Padmanabh82