Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django_table component (WIP) #100

Closed
wants to merge 7 commits into from

Conversation

Archmonger
Copy link
Contributor

Description

Implements something similar to DjangoTables2, except as an IDOM component.

Since Django users frequently use both tables and forms, this PR will eventually be followed up by a DjangoForm counterpart.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger changed the title DjangoTable django_table component (WIP) Oct 3, 2022
@Archmonger Archmonger linked an issue Oct 3, 2022 that may be closed by this pull request
@Archmonger
Copy link
Contributor Author

Archmonger commented Oct 19, 2022

I think it might be more proper for me to base this design off of the Material UI Table or TanStack Table, rather than DjangoTables2.

Frankly the DjangoTables2 interface is ugly stuff, and our framework is React styled to begin with so imitating Django packages within Django-IDOM doesn't make sense.

@rmorshea Do you have an opinion?

@Archmonger Archmonger closed this Dec 22, 2022
@rmorshea
Copy link
Contributor

I'm not personally familiar with any of the table implementations you mentioned. In general though I agree with your assessment - probably best to go with a reactive solution from the start rather than trying to force a more imperative interface to work.

@Archmonger Archmonger deleted the django-tables branch January 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

django_table component
2 participants