refactor: fix lint errors (#823)

Author: koba04

.eslintrc.yml

@@ -1,4 +1,4 @@
-parser: babel-eslint
+parser: '@typescript-eslint/parser'
 extends:
   - jason/react
   - plugin:jsx-a11y/recommended
@@ -11,8 +11,9 @@ env:
   browser: true
 plugins:
   - jsx-a11y
+  - '@typescript-eslint'
 rules:
-  "@typescript-eslint/no-unused-vars":
+  '@typescript-eslint/no-unused-vars':
     - error
     - ignoreRestSiblings: true
 

.size-snapshot.json

@@ -1,12 +1,12 @@
 {
   "lib/dist/react-transition-group.js": {
-    "bundled": 101943,
-    "minified": 26331,
-    "gzipped": 8046
+    "bundled": 98066,
+    "minified": 26272,
+    "gzipped": 8027
   },
   "lib/dist/react-transition-group.min.js": {
-    "bundled": 58919,
-    "minified": 18068,
-    "gzipped": 5664
+    "bundled": 55134,
+    "minified": 17999,
+    "gzipped": 5654
   }
 }

package.json

@@ -87,8 +87,8 @@
     "@types/react": "^17.0.41",
     "@types/react-dom": "^17.0.14",
     "@typescript-eslint/eslint-plugin": "^4.26.1",
+    "@typescript-eslint/parser": "4",
     "astroturf": "^0.10.4",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.3",
     "babel-plugin-transform-react-remove-prop-types": "^0.4.24",
     "babel-preset-jason": "^6.2.0",

src/CSSTransition.tsx

@@ -259,7 +259,7 @@ class CSSTransition extends React.Component<Props> {
   }
 
   render() {
-    const { classNames: _, ...props } = this.props;
+    const { classNames, ...props } = this.props;
 
     return (
       <Transition

src/Transition.tsx

@@ -610,20 +610,20 @@ class Transition extends React.Component<Props, State> {
       children,
       // filter props for `Transition`
       in: _in,
-      mountOnEnter: _mountOnEnter,
-      unmountOnExit: _unmountOnExit,
-      appear: _appear,
-      enter: _enter,
-      exit: _exit,
-      timeout: _timeout,
-      addEndListener: _addEndListener,
-      onEnter: _onEnter,
-      onEntering: _onEntering,
-      onEntered: _onEntered,
-      onExit: _onExit,
-      onExiting: _onExiting,
-      onExited: _onExited,
-      nodeRef: _nodeRef,
+      mountOnEnter,
+      unmountOnExit,
+      appear,
+      enter,
+      exit,
+      timeout,
+      addEndListener,
+      onEnter,
+      onEntering,
+      onEntered,
+      onExit,
+      onExiting,
+      onExited,
+      nodeRef,
       ...childProps
     } = this.props;
 

src/TransitionGroup.tsx

@@ -120,12 +120,7 @@ class TransitionGroup extends React.Component<Props, State> {
     const { contextValue } = this.state;
     // @ts-expect-error FIXME: Type 'undefined' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'.ts(2345)
     const children = values(this.state.children).map(childFactory);
-    const {
-      appear: _appear,
-      enter: _enter,
-      exit: _exit,
-      ...delegatingProps
-    } = props;
+    const { appear, enter, exit, ...delegatingProps } = props;
 
     if (Component === null) {
       return (

test/SSR-test.js

@@ -3,6 +3,7 @@
  */
 
 // test that import does not crash
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 import * as ReactTransitionGroup from '../src'; // eslint-disable-line no-unused-vars
 
 describe('SSR', () => {

yarn.lock

@@ -4118,6 +4118,16 @@
     eslint-scope "^5.1.1"
     eslint-utils "^3.0.0"
 
+"@typescript-eslint/parser@4":
+  version "4.33.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-4.33.0.tgz#dfe797570d9694e560528d18eecad86c8c744899"
+  integrity sha512-ZohdsbXadjGBSK0/r+d87X0SBmKzOq4/S5nzK6SBgJspFo9/CUDJ7hjayuze+JK7CZQLDMroqytp7pOcFKTxZA==
+  dependencies:
+    "@typescript-eslint/scope-manager" "4.33.0"
+    "@typescript-eslint/types" "4.33.0"
+    "@typescript-eslint/typescript-estree" "4.33.0"
+    debug "^4.3.1"
+
 "@typescript-eslint/parser@^4.9.1":
   version "4.26.1"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-4.26.1.tgz#cecfdd5eb7a5c13aabce1c1cfd7fbafb5a0f1e8e"
@@ -4136,11 +4146,24 @@
     "@typescript-eslint/types" "4.26.1"
     "@typescript-eslint/visitor-keys" "4.26.1"
 
+"@typescript-eslint/[email protected]":
+  version "4.33.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-4.33.0.tgz#d38e49280d983e8772e29121cf8c6e9221f280a3"
+  integrity sha512-5IfJHpgTsTZuONKbODctL4kKuQje/bzBRkwHE8UOZ4f89Zeddg+EGZs8PD8NcN4LdM3ygHWYB3ukPAYjvl/qbQ==
+  dependencies:
+    "@typescript-eslint/types" "4.33.0"
+    "@typescript-eslint/visitor-keys" "4.33.0"
+
 "@typescript-eslint/[email protected]":
   version "4.26.1"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-4.26.1.tgz#9e7c523f73c34b04a765e4167ca5650436ef1d38"
   integrity sha512-STyMPxR3cS+LaNvS8yK15rb8Y0iL0tFXq0uyl6gY45glyI7w0CsyqyEXl/Fa0JlQy+pVANeK3sbwPneCbWE7yg==
 
+"@typescript-eslint/[email protected]":
+  version "4.33.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-4.33.0.tgz#a1e59036a3b53ae8430ceebf2a919dc7f9af6d72"
+  integrity sha512-zKp7CjQzLQImXEpLt2BUw1tvOMPfNoTAfb8l51evhYbOEEzdWyQNmHWWGPR6hwKJDAi+1VXSBmnhL9kyVTTOuQ==
+
 "@typescript-eslint/[email protected]":
   version "4.26.1"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-4.26.1.tgz#b2ce2e789233d62283fae2c16baabd4f1dbc9633"
@@ -4154,6 +4177,19 @@
     semver "^7.3.5"
     tsutils "^3.21.0"
 
+"@typescript-eslint/[email protected]":
+  version "4.33.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-4.33.0.tgz#0dfb51c2908f68c5c08d82aefeaf166a17c24609"
+  integrity sha512-rkWRY1MPFzjwnEVHsxGemDzqqddw2QbTJlICPD9p9I9LfsO8fdmfQPOX3uKfUaGRDFJbfrtm/sXhVXN4E+bzCA==
+  dependencies:
+    "@typescript-eslint/types" "4.33.0"
+    "@typescript-eslint/visitor-keys" "4.33.0"
+    debug "^4.3.1"
+    globby "^11.0.3"
+    is-glob "^4.0.1"
+    semver "^7.3.5"
+    tsutils "^3.21.0"
+
 "@typescript-eslint/[email protected]":
   version "4.26.1"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-4.26.1.tgz#0d55ea735cb0d8903b198017d6d4f518fdaac546"
@@ -4162,6 +4198,14 @@
     "@typescript-eslint/types" "4.26.1"
     eslint-visitor-keys "^2.0.0"
 
+"@typescript-eslint/[email protected]":
+  version "4.33.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-4.33.0.tgz#2a22f77a41604289b7a186586e9ec48ca92ef1dd"
+  integrity sha512-uqi/2aSz9g2ftcHWf8uLPJA70rUv6yuMW5Bohw+bwcuzaxQIHaKFZCKGoGXIrc9vkTJ3+0txM73K0Hq3d5wgIg==
+  dependencies:
+    "@typescript-eslint/types" "4.33.0"
+    eslint-visitor-keys "^2.0.0"
+
 "@webassemblyjs/[email protected]":
   version "1.9.0"
   resolved "https://registry.yarnpkg.com/@webassemblyjs/ast/-/ast-1.9.0.tgz#bd850604b4042459a5a41cd7d338cbed695ed964"
@@ -4959,7 +5003,7 @@ axobject-query@^2.2.0:
   resolved "https://registry.yarnpkg.com/axobject-query/-/axobject-query-2.2.0.tgz#943d47e10c0b704aa42275e20edf3722648989be"
   integrity sha512-Td525n+iPOOyUQIeBfcASuG6uJsDOITl7Mds5gFyerkWiX7qhUTdYUBlSgNMyVqtSJqwpt1kXGLdUt6SykLMRA==
 
-babel-eslint@^10.0.3, babel-eslint@^10.1.0:
+babel-eslint@^10.0.3:
   version "10.1.0"
   resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.1.0.tgz#6968e568a910b78fb3779cdd8b6ac2f479943232"
   integrity sha512-ifWaTHQ0ce+448CYop8AdrQiBsGrnC+bMgfyKFdi6EsPLTAWG+QfyDeM6OH+FmWnKvEq5NnBMLvlBUPKQZoDSg==