Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide non-shaded byte-buddy/asm distribution #436

Open
turbospaces opened this issue Sep 24, 2024 · 3 comments
Open

Provide non-shaded byte-buddy/asm distribution #436

turbospaces opened this issue Sep 24, 2024 · 3 comments
Labels
for/team-attention This issue needs team attention or action type/enhancement A general enhancement

Comments

@turbospaces
Copy link

Title: Enhancement Request: Provide Distribution Without Shading ByteBuddy and ASM

Description:

I would like to propose an enhancement for the Blockhound library regarding its dependency management, specifically concerning its use of shaded versions of ByteBuddy and ASM (aka provide additional artifact).

Current Situation:

Blockhound currently shades ByteBuddy and ASM within its distribution. While this approach can help avoid version conflicts, it also leads to several downsides:

  1. Version Locking: We often have to wait for a new release of Blockhound to access newer versions of ByteBuddy and ASM, even though these libraries are essential for various projects. Same for newer version of JDK releases.
  2. Code Duplication: Since ByteBuddy and ASM are commonly used across many other open-source projects, shading them results in unnecessary duplication of code within our classpath.

Suggested Enhancement:

I recommend that the Blockhound library be distributed without shading ByteBuddy and ASM in addition to shaded one with some qualifier.

Conclusion:

I believe that this enhancement would contribute to a smoother development experience for users of Blockhound, ultimately leading to a more robust and maintainable ecosystem.

@turbospaces turbospaces added the type/enhancement A general enhancement label Sep 24, 2024
@s1rc0
Copy link

s1rc0 commented Sep 24, 2024

wow, great suggestion!
In my case, this blocks a full transition to JDK23

@violetagg violetagg added the for/team-attention This issue needs team attention or action label Sep 30, 2024
@violetagg
Copy link
Member

We are going to discuss this enhancement, meanwhile we will update the dependencies and will release 1.0.10.

@violetagg
Copy link
Member

1.0.10.RELEASE is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/team-attention This issue needs team attention or action type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants