Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 PING frame handling #3301

Open
claraccio opened this issue Jun 16, 2024 · 3 comments · May be fixed by #3612
Open

HTTP/2 PING frame handling #3301

claraccio opened this issue Jun 16, 2024 · 3 comments · May be fixed by #3612
Labels
help wanted We need contributions on this type/enhancement A general enhancement

Comments

@claraccio
Copy link

HTTP/2 has a ping/pong protocol, but I do not see how it can be customized via the reactor-netty API.

I only use HTTP/2 as a client so I do not know about the server side.

A feature that would be interesting is sending a PING frame at regular intervals (set by user), and if no PONG (PING ack) is received in a timely fashion (timeout set by user), then disconnect, and remove that connection from the pool.

@claraccio claraccio added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Jun 16, 2024
@violetagg violetagg added help wanted We need contributions on this and removed status/need-triage A new issue that still need to be evaluated as a whole labels Jun 17, 2024
@violetagg violetagg added this to the General Backlog milestone Jun 17, 2024
@violetagg
Copy link
Member

@claraccio Are you interested in providing a PR?

@raccoonback
Copy link
Contributor

@violetagg
Hello!
It seems this issue has been inactive, so I’d like to take it on.

From my understanding, the scope of the work would include:

  • Checking the connection status using ping frames in the HTTP Client
  • Closing the connection if it is deemed invalid

If I’ve missed anything or if there are additional requirements, please let me know.
I’d like to confirm before starting the work.

Thank you!

@violetagg
Copy link
Member

@violetagg Hello! It seems this issue has been inactive, so I’d like to take it on.

sure, go on

From my understanding, the scope of the work would include:

  • Checking the connection status using ping frames in the HTTP Client
  • Closing the connection if it is deemed invalid

yes that's correct

If I’ve missed anything or if there are additional requirements, please let me know. I’d like to confirm before starting the work.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need contributions on this type/enhancement A general enhancement
Projects
None yet
3 participants