-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket compression extension should not depends on SimpleCompressionHandler #970
Labels
type/bug
A general bug
Milestone
Comments
amizurov
added
status/need-triage
A new issue that still need to be evaluated as a whole
type/bug
A general bug
labels
Jan 24, 2020
violetagg
removed
the
status/need-triage
A new issue that still need to be evaluated as a whole
label
Jan 24, 2020
violetagg
added a commit
that referenced
this issue
Jan 24, 2020
…es there is a compressionPredicate
We will provide a WebSocket configuration for compression on/off |
@amizurov @rstoyanchev PTAL PR #980 In 0.9.x versions we will keep both ways for specifying compression on/off for WebSocket (on HTTP level and the new way with the WebSocket configuration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
If compression is enabled on the server side then WebSocket compression extensions should be applied according to https://tools.ietf.org/html/rfc7692#section-5 and not depend on
SimpleCompressionHandler
present in pipeline or not.Actual Behavior
Configure
HttpServer
with enable compression and setmaxResponseSize
to value grate than zero, WebSocket compression never applied.Steps to Reproduce
Possible Solution
Change logic inside
WebsocketServerOperations
constructor.Your Environment
netty
): 4.1.45.Finaljavar -version
): 1.8.0_232uname -a
): Darwin Kernel Version 18.7.0: Sun Dec 1 18:59:03 PST 2019; root:xnu-4903.278.19~1/RELEASE_X86_64 x86_64The text was updated successfully, but these errors were encountered: