Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-board.js #91

Closed
wants to merge 1 commit into from
Closed

Update dev-board.js #91

wants to merge 1 commit into from

Conversation

xstable
Copy link
Contributor

@xstable xstable commented Oct 18, 2020

Description

  • Shuffle the order of devs

Summary of Changes

  • added a shuffle-function for the dev's Array

Closes #90

Shuffle the order of devs
This fix #90
@netlify
Copy link

netlify bot commented Oct 18, 2020

Deploy request for reactjs-ph-website rejected.

Rejected with commit f7172d3

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

Copy link
Collaborator

@codekcv codekcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xstable, hi! Awesome. Can you please extract this array function into src/utils.js. Thanks!

Another thing, we see that you're using this.
stackoverflow.com/questions/2450954/how-to-randomize-shuffle-a-javascript-array

This is fine. But can you use the shorter and more optimized version (Durstenfeld shuffle algorithm) found in that same SO question and update to use ES6 (change to arrow fn, let, const, etc). Thanks!

@xstable xstable mentioned this pull request Oct 21, 2020
@xstable
Copy link
Contributor Author

xstable commented Oct 24, 2020

@codekcv anything fine with it now?

@codekcv
Copy link
Collaborator

codekcv commented Oct 26, 2020

@codekcv anything fine with it now?

All good, I'm closing this PR now since you opened a different one for this issue. Great work man!

@codekcv codekcv closed this Oct 26, 2020
codekcv added a commit that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomize the order of each dev box each render of the dev board.
2 participants