We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#380, #375
The CFI blacklist to have one single source of truth
The CFI blacklist is duplicated in the ReflowableView and OnePageView
The issues referenced here were caused because one of the cfi blacklist set went out of sync from the other.
The text was updated successfully, but these errors were encountered:
https://github.com/readium/readium-shared-js/blob/develop/js/views/one_page_view.js#L983
return new CfiNavigationLogic({ $iframe: _$iframe, frameDimensions: getFrameDimensions, visibleContentOffsets: getVisibleContentOffsets, classBlacklist: ["cfi-marker", "mo-cfi-highlight", "resize-sensor", "resize-sensor-expand", "resize-sensor-shrink", "resize-sensor-inner"], elementBlacklist: [], idBlacklist: ["MathJax_Message", "MathJax_SVG_Hidden"] });
Sorry, something went wrong.
https://github.com/readium/readium-shared-js/blob/develop/js/views/reflowable_view.js#L63
var _cfiClassBlacklist = ["cfi-marker", "mo-cfi-highlight", "resize-sensor", "resize-sensor-expand", "resize-sensor-shrink", "resize-sensor-inner"]; var _cfiElementBlacklist = []; var _cfiIdBlacklist = ["MathJax_Message", "MathJax_SVG_Hidden"];
Related issue (Feb. 2015): readium/readium-cfi-js#30
No branches or pull requests
This issue is a Code Cleaning Task
Related issue(s) and/or pull request(s)
#380, #375
Expected
The CFI blacklist to have one single source of truth
Observed
The CFI blacklist is duplicated in the ReflowableView and OnePageView
Additional Information
The issues referenced here were caused because one of the cfi blacklist set went out of sync from the other.
The text was updated successfully, but these errors were encountered: