Skip to content

Commit d713434

Browse files
authored
feat: supporting node 18, dropping node 12 (#295)
* feat: supporting node 18, dropping node 12 * fix: upgrading @readme/variable to support node 18
1 parent 2174a06 commit d713434

File tree

3 files changed

+22
-21
lines changed

3 files changed

+22
-21
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,25 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [14.x, 16.x]
12+
node:
13+
- 14
14+
- 16
15+
- 18
1316
react: [16, 17]
1417

15-
name: build (${{ matrix.node-version }} w/ React ${{ matrix.react }}
18+
name: build (${{ matrix.node }} w/ React ${{ matrix.react }}
1619

1720
steps:
1821
- uses: actions/checkout@v3
1922

20-
- name: Use Node.js ${{ matrix.node-version }}
23+
- name: Use Node.js ${{ matrix.node }}
2124
uses: actions/setup-node@v3
2225
with:
23-
node-version: ${{ matrix.node-version }}
26+
node-version: ${{ matrix.node }}
2427

28+
# Node 14 still ships with npm@6 which doesn't install peerDeps by default.
2529
- name: Install npm@7
30+
if: matrix.node == '14'
2631
run: npm install -g npm@7
2732

2833
- name: Install dependencies

package-lock.json

Lines changed: 12 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"homepage": "https://readmeio.github.io/syntax-highlighter/",
1313
"engines": {
14-
"node": "^14 || ^16"
14+
"node": ">=14"
1515
},
1616
"scripts": {
1717
"build": "webpack --progress",

0 commit comments

Comments
 (0)