Skip to content

Enable atomic requests #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

Enable atomic requests #1088

merged 1 commit into from
Nov 10, 2025

Conversation

@davidfischer
Copy link
Collaborator

@davidfischer davidfischer commented Oct 23, 2025

No description provided.

@davidfischer davidfischer requested a review from a team as a code owner October 23, 2025 21:51
@davidfischer
Copy link
Collaborator Author

davidfischer commented Oct 24, 2025

I thought this was already on (

ethical-ad-server/config/settings/base.py

Line 146 in e39fec6

DATABASES["default"]["ATOMIC_REQUESTS"] = True
), but it was being overwritten in the production settings. I noticed while working on DB pooling.

@davidfischer davidfischer merged commit cce9230 into main Nov 10, 2025
1 check passed
@davidfischer davidfischer deleted the davidfischer/enable-atomic-requests branch November 10, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidfischer @ericholscher