Remove DONT_CLEAN_BUILD feature flag (#12519)

Ref
#12462 (comment)

Author: stsewd

readthedocs/projects/models.py

@@ -1983,7 +1983,6 @@ def add_features(sender, **kwargs):
     SCALE_IN_PROTECTION = "scale_in_prtection"
     USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS = "use_s3_scoped_credentials_on_builders"
     BUILD_FULL_CLEAN = "build_full_clean"
-    DONT_CLEAN_BUILD = "dont_clean_build"
     BUILD_HEALTHCHECK = "build_healthcheck"
     BUILD_NO_ACKS_LATE = "build_no_acks_late"
 
@@ -2039,12 +2038,6 @@ def add_features(sender, **kwargs):
             USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS,
             _("Build: Use S3 scoped credentials for uploading build artifacts."),
         ),
-        (
-            DONT_CLEAN_BUILD,
-            _(
-                "Build: Don't clean the build directory. Only for Enterprise users with dedicated builders."
-            ),
-        ),
         (
             BUILD_FULL_CLEAN,
             _("Build: Clean all build directories to avoid leftovers from other projects."),

readthedocs/projects/tasks/utils.py

@@ -17,7 +17,6 @@
 from readthedocs.core.utils.filesystem import safe_rmtree
 from readthedocs.doc_builder.exceptions import BuildAppError
 from readthedocs.notifications.models import Notification
-from readthedocs.projects.models import Feature
 from readthedocs.storage import build_media_storage
 from readthedocs.worker import app
 
@@ -27,17 +26,6 @@
 
 def clean_build(version=None):
     """Clean the files used in the build of the given version."""
-
-    if version and version.project.has_feature(
-        Feature.DONT_CLEAN_BUILD,
-    ):
-        log.info(
-            "Skipping cleaning build files for project with DONT_CLEAN_BUILD feature.",
-            project_slug=version.project.slug,
-            version_slug=version.slug,
-        )
-        return
-
     if version:
         del_dirs = [
             os.path.join(version.project.doc_path, dir_, version.slug)

readthedocs/vcs_support/backends/git.py

@@ -1,6 +1,5 @@
 """Git-related utilities."""
 
-import os
 import re
 from typing import Iterable
 from urllib.parse import urlparse
@@ -53,14 +52,6 @@ def update(self):
                     code, stdout, stderr = self.run(*cmd.split(), escape_command=False)
                 return
 
-        # Check for existing checkout and skip clone if it exists.
-        from readthedocs.projects.models import Feature
-
-        if self.project.has_feature(Feature.DONT_CLEAN_BUILD) and os.path.exists(
-            os.path.join(self.working_dir, ".git")
-        ):
-            return self.fetch()
-
         self.clone()
         # TODO: We are still using return values in this function that are legacy.
         # This should be either explained or removed.