Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GazeProvider a proper controller #78

Open
FejZa opened this issue Aug 27, 2023 · 1 comment
Open

Make GazeProvider a proper controller #78

FejZa opened this issue Aug 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request feature approved

Comments

@FejZa
Copy link
Contributor

FejZa commented Aug 27, 2023

Overview

The gaze provider has always been a bit of a weird curiosity in the toolkit. It's time to mature it into a proper controller that makes it more versatile and usable.

Proposed changes

  • Introduce controller type "GazeController" operated by a default "Gaze Controller Service Module" of the input service
  • The GazeController operates and behaves just as before but is treated as a proper controller by the input service that can easily be configued or disabled via the service module

Benefits

  • Follows proper architecture and design principles of the toolkit
  • Sets the foundation for special Gaze Controllers, such as an "Eye Tracking Gaze Controller"
@FejZa FejZa added the enhancement New feature or request label Aug 27, 2023
@FejZa FejZa self-assigned this Aug 27, 2023
@SimonDarksideJ
Copy link
Contributor

Another thing to factor in this upgrade, is due to the GazeProvider currently causing a Null ref exception onDisable due to the Input Service being unregistered.
As a module, it would not have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature approved
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants