Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import standard assets to project when a module is installed #72

Open
FejZa opened this issue Jan 25, 2023 · 6 comments
Open

Import standard assets to project when a module is installed #72

FejZa opened this issue Jan 25, 2023 · 6 comments
Assignees
Labels
feature request New feature request

Comments

@FejZa
Copy link
Contributor

FejZa commented Jan 25, 2023

Reality Collective - Reality Toolkit Feature Request

All standard assets, such as materials, must be imported into the projects assets folder and not live in the package itself. We need to move them to the modules respective RealityToolkit.Generated/XYZ/Assets folder. This is specifically important so that default materials can be converted to URP / HDRP as needed.

@FejZa FejZa added the feature request New feature request label Jan 25, 2023
@SimonDarksideJ SimonDarksideJ self-assigned this Jan 25, 2023
@SimonDarksideJ
Copy link
Contributor

Not an issue, we already have a packaging system there, so likely it will need expanding regarding materials and shaders. Textures should still be fine in the package

Does raise a question about whether it should be "automatically" imported when a package is added, or still a manual task. Currently the user is required to install the package from the Editor menu.

@FejZa
Copy link
Contributor Author

FejZa commented Jan 26, 2023

There is no point in keeping textures in the package. Why? Everything that the user might want to alter should be imported into assets. Especially since we already have a system in place, that does exactly that (PackageInstaller)

@FejZa
Copy link
Contributor Author

FejZa commented Jan 26, 2023

Is it really manual? If I remember correctly users get prompted to install after adding a package

@SimonDarksideJ
Copy link
Contributor

SimonDarksideJ commented Jan 26, 2023

Is it really manual? If I remember correctly users get prompted to install after adding a package

Yes, you get the option when the package is installed but if you install multiple at the same time it sometimes does not and if you haven't configured a scene yet, it can get in the way

Why? Everything that the user might want to alter should be imported into assets.

No sense in duplicating textures as they are read-only anyway, they can use the ones in the package or replace them with their own in their project. If we ever did replace a texture for whatever reason, there would then be a conflict.
Unavoidable with shaders/materials as they can be updated during edit/runtime.
That's been my experience, especially dealing with the MRTK as materials get updated by their scripts and then overwritten when the editor does a reload and resets from cache.

@FejZa
Copy link
Contributor Author

FejZa commented Jan 26, 2023

Got it. Definitely something to look at but not urgent at this point IMO.

@SimonDarksideJ
Copy link
Contributor

Got it. Definitely something to look at but not urgent at this point IMO.

Agreed, we just need to expand the scope of what is copied to the project for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants