From 782593572f9ef08c7418478597cd3b109e0c4397 Mon Sep 17 00:00:00 2001 From: Christian Melchior Date: Tue, 28 Nov 2023 16:43:26 +0100 Subject: [PATCH] More PR feedback --- .../kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt | 2 +- .../kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt | 2 ++ .../realm/kotlin/test/mongodb/common/AppConfigurationTests.kt | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt b/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt index 6a57be56bd..c638e25317 100644 --- a/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt +++ b/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt @@ -105,7 +105,7 @@ public interface AppConfiguration { public val httpLogObfuscator: HttpLogObfuscator? /** - * If enabled (the default), a single connection is used for all Realms opened + * If enabled, a single connection is used for all Realms opened * with a single sync user. If disabled, a separate connection is used for each * Realm. * diff --git a/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt b/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt index 33783303f2..173b6041c1 100644 --- a/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt +++ b/packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt @@ -20,6 +20,8 @@ import kotlin.time.Duration /** * The configured timeouts for various aspects of the sync connection between synchronized realms * and App Services. + * + * @see [io.realm.kotlin.mongodb.AppConfiguration.Builder.syncTimeouts] */ public data class SyncTimeoutOptions( diff --git a/packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppConfigurationTests.kt b/packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppConfigurationTests.kt index 819e00dee7..5ae187ebad 100644 --- a/packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppConfigurationTests.kt +++ b/packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppConfigurationTests.kt @@ -499,9 +499,9 @@ class AppConfigurationTests { @Test fun multiplexing() { val config = AppConfiguration.Builder("foo") - .enableSessionMultiplexing(false) + .enableSessionMultiplexing(true) .build() - assertFalse(config.enableSessionMultiplexing) + assertTrue(config.enableSessionMultiplexing) } @Test