Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow id of notifications to be specified #269

Open
steppy452 opened this issue Dec 4, 2024 · 0 comments
Open

Allow id of notifications to be specified #269

steppy452 opened this issue Dec 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@steppy452
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Notification ids are currently kept track internally and have no way of being retrieved for clearNotification callback in notifications hook to be used.

Expected behavior

Proposing ability to pass an optional id parameter when creating notifications which can later be used to clear specific notification (or even notification group, if the same id is used for multiple notification). We'll still want to keep the current internal id to ensure uniqueness

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Necessary for manual clearing of specific notification(s) which isn't coming directly from using the "close" button on the notification

Environment


Libs:
- react version: X.Y.Z
- reablocks version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@steppy452 steppy452 added the enhancement New feature or request label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant