Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox component is broken with styled-components v5x.x #1049

Open
javiercr opened this issue Nov 15, 2020 · 3 comments · May be fixed by #1050
Open

Checkbox component is broken with styled-components v5x.x #1049

javiercr opened this issue Nov 15, 2020 · 3 comments · May be fixed by #1050

Comments

@javiercr
Copy link

Hi,

We've upgraded our project from styled-components v4 to v5 and we've noticed that the rebass Checkbox form is now broken: the checkbox icon doesn't render when the checkbox is checked, it only renders properly when is disabled.

Here is a repro:
with styled-components v4 (everything works fine)
https://codesandbox.io/s/elastic-water-h1rg6

with styled-components v5 (Checkbox broken)
https://codesandbox.io/s/gallant-heyrovsky-cxbc0

I've taken a look to the styled-components changelog but haven't found anything change that I could associate with the described problem.

PS: thank you for rebass, it's an amazing library :)

@javiercr
Copy link
Author

Apparently the same problem applies to <Radio>. It seems to be related to styled-components/styled-components#3265.

There is a workaround suggested on styled-components/styled-components#3244 (comment) that seems to work.

I'll open a PR with that fix.

javiercr pushed a commit to javiercr/rebass that referenced this issue Nov 15, 2020
@evenromo
Copy link

evenromo commented Dec 1, 2020

Where are we on this one? Would be nice to have the fix merged

@anvitrola
Copy link

Where are we on this one? Would be nice to have the fix merged
I'm having the same issue :/ it would be very nice to have it fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants