From 8f819ade0ce52c2dce7dd5cde6e85ad21c8b852a Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Fri, 22 Nov 2024 09:27:50 +0100 Subject: [PATCH 1/2] chore(dev): run phpstsan with 8.4 --- .github/workflows/analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml index 7265ab86..a5c3e413 100644 --- a/.github/workflows/analysis.yml +++ b/.github/workflows/analysis.yml @@ -32,7 +32,7 @@ jobs: - uses: shivammathur/setup-php@v2 with: - php-version: 8.3 + php-version: 8.4 coverage: none # Remove unnecessary dependencies not needed in this context From 0365fe1fb63407b777857e629c5b86b3a9a69bb0 Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Fri, 22 Nov 2024 09:44:33 +0100 Subject: [PATCH 2/2] test: Add explicit nullable type declaration Fixes PHP 8.4 compat --- .../AuthorizeArgsTests/TestAuthorizationArgsQuery.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php b/tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php index 6944c77b..52baa1cb 100644 --- a/tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php +++ b/tests/Database/AuthorizeArgsTests/TestAuthorizationArgsQuery.php @@ -34,8 +34,8 @@ public function authorize( $root, array $args, $ctx, - ResolveInfo $resolveInfo = null, - Closure $getSelectFields = null + ?ResolveInfo $resolveInfo = null, + ?Closure $getSelectFields = null ): bool { Assert::assertNull($root);