From 1878f2b55a3393ef933f0fecc11b7d7262f6e821 Mon Sep 17 00:00:00 2001 From: Fabian Steeg Date: Wed, 9 Oct 2024 17:08:23 +0200 Subject: [PATCH] Use string objects in property proposals, update changelog (#138) Also add `description` to spec and example (was in schema already) --- .../valid/response.json | 57 +++++++++++++++++-- draft/index.html | 4 +- .../data-extension-property-proposal.json | 14 +++-- 3 files changed, 63 insertions(+), 12 deletions(-) diff --git a/draft/examples/data-extension-property-proposal/valid/response.json b/draft/examples/data-extension-property-proposal/valid/response.json index 55a1868..318923b 100644 --- a/draft/examples/data-extension-property-proposal/valid/response.json +++ b/draft/examples/data-extension-property-proposal/valid/response.json @@ -4,23 +4,68 @@ "properties": [ { "id": "affiliation", - "name": "Affiliation" + "name": [ + { + "str": "Affiliation" + } + ], + "description": [ + { + "str": "A corporate body associated with a person or group of persons." + } + ] }, { "id": "geographicAreaCode", - "name": "Ländercode" + "name": [ + { + "str": "Geographic Area Code", + "lang": "en" + }, + { + "str": "Ländercode", + "lang": "de" + } + ] }, { "id": "preferredName", - "name": "Bevorzugter Name" + "name": [ + { + "str": "Preferred name", + "lang": "en" + }, + { + "str": "Bevorzugter Name", + "lang": "de" + } + ] }, { "id": "professionOrOccupation", - "name": "Beruf oder Beschäftigung" + "name": [ + { + "str": "Profession or occupation", + "lang": "en" + }, + { + "str": "Beruf oder Beschäftigung", + "lang": "de" + } + ] }, { "id": "variantName", - "name": "Varianter Name" + "name": [ + { + "str": "Variant name", + "lang": "en" + }, + { + "str": "Varianter Name", + "lang": "de" + } + ] } ] -} \ No newline at end of file +} diff --git a/draft/index.html b/draft/index.html index 1c1f42c..8c13999 100644 --- a/draft/index.html +++ b/draft/index.html @@ -242,7 +242,7 @@

This Draft

  • Move the query field of reconciliation queries inside properties to allow for queries which do not provide entity names
  • Add optional standardizedScore field to the manifest
  • Unify naming to camelCase convention
  • -
  • Change candidate name and description from string to array of objects with required str, optional lang and dir fields
  • +
  • For objects selected by users (candidates, suggest responses, property proposals), change name and description from string to array of objects with required str, optional lang and dir fields
  • @@ -868,7 +868,7 @@

    Data Extension Property Proposals

    A data extension property proposal response consists of:
    properties
    -
    An array of proposed properties. These properties are suggested as fields that could be potentially fetched via data extension for entities of the type provided in the query;
    +
    An array of objects representing the proposed properties, each containing an id (as a string), a name and optionally a description (both as an array of string objects). These properties are suggested as fields that could be potentially fetched via data extension for entities of the type provided in the query;
    type
    The type identifier supplied in the query;
    limit
    diff --git a/draft/schemas/data-extension-property-proposal.json b/draft/schemas/data-extension-property-proposal.json index 3aa2f00..64a15a7 100644 --- a/draft/schemas/data-extension-property-proposal.json +++ b/draft/schemas/data-extension-property-proposal.json @@ -14,12 +14,18 @@ "description": "Identifier of the suggested property" }, "name": { - "type": "string", - "description": "Name of the suggested property" + "type": "array", + "description": "Name of the suggested property", + "items": { + "$ref": "string-object.json" + } }, "description": { - "type": "string", - "description": "An optional description which can be provided to disambiguate namesakes, providing more context." + "type": "array", + "description": "An optional description which can be provided to disambiguate namesakes, providing more context.", + "items": { + "$ref": "string-object.json" + } } }, "required": [