From c091bfbe1549de612d79b944a3d8d7fa4c9334df Mon Sep 17 00:00:00 2001 From: Petr Balogh Date: Fri, 2 Aug 2024 09:56:05 +0200 Subject: [PATCH] Fix condition for verify_disks_lso_attached This PR: https://github.com/red-hat-storage/ocs-ci/pull/10120 Broke original condition: if config.ENV_DATA.get("platform") != constants.BAREMETAL_PLATFORM: and changed to: if config.ENV_DATA.get("platform") in [ constants.BAREMETAL_PLATFORM, constants.HCI_BAREMETAL, ]: There should be `not in`. Which is fixed in this commit. Signed-off-by: Petr Balogh --- ocs_ci/ocs/ui/base_ui.py | 2 +- ocs_ci/ocs/ui/deployment_ui.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ocs_ci/ocs/ui/base_ui.py b/ocs_ci/ocs/ui/base_ui.py index 44203ab8eb7..0684f12faa8 100644 --- a/ocs_ci/ocs/ui/base_ui.py +++ b/ocs_ci/ocs/ui/base_ui.py @@ -365,7 +365,7 @@ def check_element_text(self, expected_text, element="*", take_screenshot=False): Args: expected_text (string): The expected text. - element (str): element (default: *) + element (str): element take_screenshot (bool): if screenshot should be taken return: diff --git a/ocs_ci/ocs/ui/deployment_ui.py b/ocs_ci/ocs/ui/deployment_ui.py index 275fdddf4a0..d2d7fcda421 100644 --- a/ocs_ci/ocs/ui/deployment_ui.py +++ b/ocs_ci/ocs/ui/deployment_ui.py @@ -237,7 +237,7 @@ def install_lso_cluster(self): self.do_click( locator=self.dep_loc["all_nodes_create_sc"], enable_screenshot=True ) - if config.ENV_DATA.get("platform") in [ + if config.ENV_DATA.get("platform") not in [ constants.BAREMETAL_PLATFORM, constants.HCI_BAREMETAL, ]: