From cd5d9cad8e4f7498cbac6a74d6a5add3daaec63a Mon Sep 17 00:00:00 2001 From: Petr Balogh Date: Thu, 23 Jan 2025 22:46:29 +0100 Subject: [PATCH] Fix memory leak in Get bucket replication test Fixes: #11218 Signed-off-by: Petr Balogh --- .../object/mcg/test_bucket_replication.py | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/functional/object/mcg/test_bucket_replication.py b/tests/functional/object/mcg/test_bucket_replication.py index 57ebc6fb013..5a836020e33 100644 --- a/tests/functional/object/mcg/test_bucket_replication.py +++ b/tests/functional/object/mcg/test_bucket_replication.py @@ -1,4 +1,5 @@ import logging +import gc import pytest @@ -492,11 +493,14 @@ def test_unidirectional_bucketclass_replication( def check_nb_endpoint_logs(): for pod in get_noobaa_endpoint_pods(): + pod_logs = get_pod_logs(pod.name) if ( "The AWS access key Id you provided does not exist in our records" - in get_pod_logs(pod.name) + in pod_logs ): return True + del pod_logs + gc.collect() return False sample = TimeoutSampler(timeout=360, sleep=10, func=check_nb_endpoint_logs) @@ -521,12 +525,13 @@ def check_nb_endpoint_logs(): # check in noobaa core logs def check_noobaa_core_logs(): - if "find_rules_updated_longest_time_ago: []" in get_pod_logs( - get_noobaa_core_pod().name - ): - return True - else: - return False + found = False + pod_logs = get_pod_logs(get_noobaa_core_pod().name) + if "find_rules_updated_longest_time_ago: []" in pod_logs: + found = True + del pod_logs + gc.collect() + return found logger.info( f"Checking the noobaa core logs to see if the replication has "