Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of having 2 functions for reclaim space in helpers.py that use the same code, make one #10111

Closed
ypersky1980 opened this issue Jul 15, 2024 · 2 comments
Assignees
Labels
lifecycle/stale No recent activity

Comments

@ypersky1980
Copy link
Contributor

There are 2 similar functions in ocs_ci/helpers/helpers.py

def wait_for_reclaim_space_cronjob(reclaim_space_cron_job, schedule)

def wait_for_reclaim_space_job(reclaim_space_job)

Those functions has similar code in common and some differences.

Please addess Elad's comment in #10096 and make one function instead of two.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale No recent activity label Oct 13, 2024
Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale No recent activity
Projects
None yet
Development

No branches or pull requests

1 participant