diff --git a/ofrak_core/CHANGELOG.md b/ofrak_core/CHANGELOG.md index 5048a2cac..5fcd5df82 100644 --- a/ofrak_core/CHANGELOG.md +++ b/ofrak_core/CHANGELOG.md @@ -37,6 +37,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Fix bugs on Windows arising from using `os.path` methods when only forward-slashes are acceptable ([#521](https://github.com/redballoonsecurity/ofrak/pull/521)) - Made some changes to OFRAK test suite to improve test coverage on Windows ([#487](https://github.com/redballoonsecurity/ofrak/pull/487)) - Fix usage of `NamedTemporaryFile` with external tools on Windows ([#486](https://github.com/redballoonsecurity/ofrak/pull/486)) +- Fix unintentional ignoring of cpio errors introduced in [#486](https://github.com/redballoonsecurity/ofrak/pull/486) ([#555](https://github.com/redballoonsecurity/ofrak/pull/555])) ### Changed - By default, the ofrak log is now `ofrak-YYYYMMDDhhmmss.log` rather than just `ofrak.log` and the name can be specified on the command line ([#480](https://github.com/redballoonsecurity/ofrak/pull/480)) diff --git a/ofrak_core/ofrak/core/cpio.py b/ofrak_core/ofrak/core/cpio.py index 685701990..d1516856c 100644 --- a/ofrak_core/ofrak/core/cpio.py +++ b/ofrak_core/ofrak/core/cpio.py @@ -100,8 +100,8 @@ async def unpack(self, resource: Resource, config=None): cwd=temp_flush_dir, ) await proc.communicate(input=resource_data) - # if proc.returncode: - # raise CalledProcessError(returncode=proc.returncode, cmd=cmd) + if proc.returncode: + raise CalledProcessError(returncode=proc.returncode, cmd=cmd) await cpio_v.initialize_from_disk(temp_flush_dir)