You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding new feature support to ofrak and ofrak_patch_maker should not require forking this repository to modify internal types or hacking together fake Enum member objects. We should use bare Enum when it's suitably internal and not intended to be extensible or it's possible to actually enumerate all possible options (endianness, memory permissions, etc. probably qualify here).
Example of Enums that shouldn't be
ElfSectionType
ElfProgramHeaderType
Every Enum in ofrak_type.architecture
Does the feature contain any proprietary information about another company's intellectual property?
No.
How would you implement this feature?
Changing "feature" Enums to inherit from StrEnum or IntEnum and update typedefs in consuming classes/methods to str or int.
Are you interested in implementing it yourself?
Yes.
The text was updated successfully, but these errors were encountered:
What is the use case for the feature?
Adding new feature support to
ofrak
andofrak_patch_maker
should not require forking this repository to modify internal types or hacking together fake Enum member objects. We should use bareEnum
when it's suitably internal and not intended to be extensible or it's possible to actually enumerate all possible options (endianness, memory permissions, etc. probably qualify here).Example of
Enum
s that shouldn't beElfSectionType
ElfProgramHeaderType
Enum
inofrak_type.architecture
Does the feature contain any proprietary information about another company's intellectual property?
No.
How would you implement this feature?
Changing "feature"
Enum
s to inherit fromStrEnum
orIntEnum
and update typedefs in consuming classes/methods tostr
orint
.Are you interested in implementing it yourself?
Yes.
The text was updated successfully, but these errors were encountered: