Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Behavior: Adding a View Overwrites the Existing View #537

Open
whyitfor opened this issue Dec 16, 2024 · 0 comments
Open

Unexpected Behavior: Adding a View Overwrites the Existing View #537

whyitfor opened this issue Dec 16, 2024 · 0 comments

Comments

@whyitfor
Copy link
Contributor

In OFRAK, it is possible to add a ResourceView to an existing resource.

If that resource already has that view, this is essentially updating the existing view's data. An example of this being used is here: https://github.com/redballoonsecurity/ofrak/blob/master/disassemblers/ofrak_ghidra/ofrak_ghidra/components/ghidra_analyzer.py#L463.

This is very confusing behavior: add_view sounds like it is adding something, not replacing it.

Possible solutions:

  • Saving added view should fail if they update the view?
  • Another option?

Which files would be affected?

Does the proposed maintenance include non-doc string functional changes to the Python code?

Are you interested in implementing it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant