-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize the AppStream metadata #1575
base: master
Are you sure you want to change the base?
Conversation
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic
(Do not worry about the previous sentence about lowercase letters. Even GNOME uses a mix of lowercase and uppercase for app IDs and there are no problems with it.) |
@Calinou Any chance you could also merge this PR? :) |
Oh! I thought that all members of an organization on GitHub (GitLab) should have write access to its repos. |
There's only a handful of people with write access to the base repository because it automatically deploys via continuous integration and to prevent people pushing changes without core developer oversight. I'm currently taking a break from administrative duties and only working on personal tasks unless deemed critical. I'm aware of this ticket, and after taking a look at it I have determined it requires further research and modification by me before being merged. It certainly isn't important enough to be constantly @'ing project moderators. I am also not happy with the fact that the file contains both static and dynamic information, as the former makes the latter pretty pointless. With the current setup it doesn't even make sense to declare the namespace like that in the Makefile as pretty much nothing else is using that information. |
Thanks for the reply!
Could I ask for some details about this modification that is required? Also, if you need any information about AppStream metadata, I can provide them. I am involved in desktop Linux development and its software distribution (including AppStream and related things) for a quite long time.
I fully agree. These dynamic information are probably not much useful (especially the app id that should be the same as id in the actual metadata file name) and could be all replaced with static ones. If any downstream packaging project wants to modify them, sed or similar tools can be used for that. |
@qreeves Any chance you could answer my questions from the previous comment? Thanks! |
did you not read his response?
They have this on the docket for when they get time to work on this again. It's a free game developed in free time. Life happens and people need to step away. |
That's exactly why I asked if they could answer my questions regarding the "required further research and modification". I could provide help. By the way, I maintain the Xonotic Flatpak on Flathub. |
It means I need to understand the subject better. I can't answer any questions until I do. Please stop @'ing me. |
Fair enough. Thanks for the clear answer! |
Since this is taking too long, I propose an alternative that is not ideal, but at least will make the AppStream metadata file valid and accepted by modern parsers:
|
04fe80e
to
1df383a
Compare
- Update description - Add missing name and summary tags - Switch to a rDNS app id format that is now required - Various fixes to make the file adhere to modern standards
1df383a
to
4fadc46
Compare
I have made a more simpler, smaller alternative to this PR here: #1599 It does not change the app id or AppStream file name and should be ready to be merged. |
Changes proposed in this request:
/cc @qreeves